Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename "placeholder" tag to "customisation", bump planx-core #4256

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: rename "placeholder" tag to "customisation", bump planx-core #4256

merged 1 commit into from
Feb 5, 2025
+84 −56

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Feb 5, 2025 •
edited
Loading

Follows on from theopensystemslab/planx-core#643 (also picking up two non-related schema PRs on main)

Key changes:

  • "Placeholder" now renamed "Customisation" per templates design call decision
  • "Customisation" tag is only visible on the graph to platformAdmins, never to anyone else (we will have a new visual design to communicate editability going forward that will not rely on the tag band)
    • Note the tag is still visible in the component modal "Tags" autocomplete to all users, but interactive or not depending on permissions, as now
As a platformAdmin As any non-admin user
Screenshot from 2025-02-05 16-08-30 Screenshot from 2025-02-05 16-09-32

@jessicamcinchak jessicamcinchak requested a review from a team February 5, 2025 15:32
DafyddLlyr
DafyddLlyr approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Nice and simple 👌

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit f4a2410 into main Feb 5, 2025
13 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/rename-placeholder-tag branch February 5, 2025 15:50
@jessicamcinchak
Copy link
Member Author

Only display "customisable" tag to platformAdmins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr