Fix bug where content type header not being added to response on json…

… strategy

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [4.0.1] 2018-08
+
+### Fixed
+- Fixed a bug where content-type header would not be added to response in Json Strategy.
+
 ## [4.0.0] 2018-08
 
 ### Changed

docs/_config.yml

@@ -2,7 +2,7 @@
 title: Route
 subtitle: The PHP League
 email: [email protected]
-description: Fast routing and dispatch component including PSR-15 middleware, built on top of FastRoute.
+description: Fast PSR-7 routing and dispatch component including PSR-15 middleware, built on top of FastRoute.
 baseurl: # the subpath of your site, e.g. /blog
 url: # the base hostname & protocol for your site
 

docs/_data/releases.yml

@@ -17,7 +17,7 @@
   name: League\Route 4.x
   type: Current
   requires: PHP >= 7.1.0
-  release: 4.0.0 - 2018-08
+  release: 4.0.1 - 2018-08
   support: Ongoing
   url: /4.x/
   menu:

src/Strategy/JsonStrategy.php

@@ -44,7 +44,7 @@ public function invokeRouteCallable(Route $route, ServerRequestInterface $reques
         }
 
         if ($response instanceof ResponseInterface && ! $response->hasHeader('content-type')) {
-            $response->withAddedHeader('content-type', 'application/json');
+            $response = $response->withAddedHeader('content-type', 'application/json');
         }
 
         return $response;

tests/Strategy/JsonStrategyTest.php

@@ -50,6 +50,13 @@ function (
             ->will($this->returnValue($expectedVars))
         ;
 
+        $expectedResponse
+            ->expects($this->once())
+            ->method('withAddedHeader')
+            ->with($this->equalTo('content-type'), $this->equalTo('application/json'))
+            ->will($this->returnSelf())
+        ;
+
         $factory = $this->createMock(ResponseFactoryInterface::class);
 
         $strategy = new JsonStrategy($factory);