-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021 07 13 rebase #33
Open
Dave-B
wants to merge
8
commits into
thepurpleblob:master
Choose a base branch
from
Dave-B:2021-07-13_rebase
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Username" is more properly the login username, which may be useful to include as an option in the report.
Moves the hard-coded status, grade, grader, modified, and extension fields into a preference, and add other grading fields: - gradevalue - actual grade value, separate from maximum grade. - grademax - maximum grade - created - submission creation date - latenessincext - how late the submission was, including any extensions The fields gradevalue and grademax are intended as an alternative to grade, suitable for further processing outside of Moodle, via spreadsheet. The default choices are set to the previous hard-coded fields. NB: This has changed the field order in the columns.
Restrict name data available to only users with report/assign:shownames.
Moves the hard-coded files column into a preference, and adds columns for whatever submission plugins are enabled.
Trying to track down which field is getting an extra column can be pretty frustrating if there's no data that can be used to identify the field - when it's just the '-' empty value placeholder. Change false to true in the placeholder() function and it will put field ids in for many (not all) placeholders.
Includes framework to adding more course fields easy.
@thepurpleblob have you had an opportunity to review this pull request? I'd like to pull from the main branch when it is merged. |
I need to release a new version of this plugin which I'll try to get to in the next few days. I'll take a look at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased onto 1.2.7 master.
Main changes:
Fixes #7.