Mobile App MVP using Firebase #1

EmperorNumerius · 2024-07-06T05:27:28Z

Pull Request

Description:

aramshiva · 2024-07-06T05:46:01Z

this works with matrix? how does and where does it store messages?

jaspermayone · 2024-07-06T09:17:23Z

This will work with our protocol

jaspermayone · 2024-07-06T09:26:24Z

@Luke-Oldenburg plz review protocol wise

Luke-Oldenburg

I get that this is just a MVP so I guess it's okay that it's firebase but can we at least get expo setup? That's a pretty big deal. Also rename all the GiftedChat stuff to Purple Bubble.

Luke-Oldenburg · 2024-07-06T13:07:16Z

.gitignore

+#
+.DS_Store
+
+secrets.env


Rename to *.env or just .env and rename the file

.gitignore

README.md

app.json

firebase.js

Luke-Oldenburg · 2024-07-06T13:13:19Z

package.json

@@ -0,0 +1,47 @@
+{
+  "name": "GiftedChatApp",


Rename this.

Luke-Oldenburg · 2024-07-06T13:26:22Z

Ultimately it's up to @jaspermayone on whether it's merged. Since I'm going to try to finish the reference implementation this weekend it would be nice if the MVP used the protocol. It's not really displaying OUR product without that.

Luke-Oldenburg · 2024-07-06T13:29:24Z

I know Sam's on vacation right now but he knows more about react native development than me so I'm tagging him for review.

Luke-Oldenburg · 2024-07-06T13:32:16Z

Also please add a PR description and remove the closes issue part once you perform these changes.

jaspermayone

Left lots of comments, app name and icon needs to be changed.

App also needs to move to Expo.

jaspermayone · 2024-07-06T15:24:33Z

.bundle/config

@@ -0,0 +1,2 @@
+BUNDLE_PATH: "vendor/bundle"
+BUNDLE_FORCE_RUBY_PLATFORM: 1


jaspermayone · 2024-07-06T15:26:05Z

.prettierrc.js

+module.exports = {
+  arrowParens: 'avoid',
+  bracketSameLine: true,
+  bracketSpacing: false,
+  singleQuote: true,
+  trailingComma: 'all',
+};


We don't have a semantic style for code we use right now, let's remove this.

It could stay for now and we discuss it at a meeting later on it. It'd be nice if each project was at least consistent in itself.

jaspermayone · 2024-07-06T15:26:14Z

.eslintrc.js

+module.exports = {
+  root: true,
+  extends: '@react-native',
+};


We don't have a semantic style for code we use right now, let's remove this.

jaspermayone · 2024-07-06T15:26:31Z

.watchmanconfig

@@ -0,0 +1 @@
+{}


What is this file and why do we need it?

jaspermayone · 2024-07-06T15:26:55Z

Gemfile

+source 'https://rubygems.org'
+
+# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
+ruby ">= 2.6.10"
+
+# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
+# bound in the template on Cocoapods with next React Native release.
+gem 'cocoapods', '>= 1.13', '< 1.15'
+gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'


If we are using react, why do we have a gemfile???

jaspermayone · 2024-07-06T15:28:05Z

android/app/src/debug/AndroidManifest.xml

+    <application
+        android:usesCleartextTraffic="true"
+        tools:targetApi="28"
+        tools:ignore="GoogleAppIndexingWarning"/>


What's the specific reason for ignoring this?

jaspermayone · 2024-07-06T15:28:38Z

android/app/src/main/AndroidManifest.xml

+      <activity
+        android:name=".MainActivity"
+        android:label="@string/app_name"
+        android:configChanges="keyboard|keyboardHidden|orientation|screenLayout|screenSize|smallestScreenSize|uiMode"
+        android:launchMode="singleTask"
+        android:windowSoftInputMode="adjustResize"
+        android:exported="true">
+        <intent-filter>
+            <action android:name="android.intent.action.MAIN" />
+            <category android:name="android.intent.category.LAUNCHER" />
+        </intent-filter>


jaspermayone · 2024-07-06T15:28:53Z

android/app/src/main/AndroidManifest.xml

+    <uses-permission android:name="android.permission.INTERNET" />
+
+    <application
+      android:name=".MainApplication"


Should this not be our app name?

jaspermayone · 2024-07-06T15:30:14Z

android/app/src/main/java/com/giftedchatapp/MainActivity.kt

@@ -0,0 +1,22 @@
+package com.giftedchatapp


change this name please!

jaspermayone · 2024-07-06T15:30:26Z

android/app/src/main/java/com/giftedchatapp/MainActivity.kt

+   * Returns the name of the main component registered from JavaScript. This is used to schedule
+   * rendering of the component.
+   */
+  override fun getMainComponentName(): String = "GiftedChatApp"


change this name please!

aramshiva · 2024-07-06T15:59:04Z

Do we want to use firebase? For a privacy/secure company I don't think it's a good idea

Luke-Oldenburg · 2024-07-06T16:43:13Z

@aramshiva we're not at all... it's a demo just of the ui. Look at all the protocol dev?

spent rest of time reading purple bubble api

Luke-Oldenburg · 2024-07-08T13:24:23Z

@EmperorNumerius the files shouldnt be nested in a PurpleBubble folder. They should be in the root directory. The code should be in a src folder though.

Luke-Oldenburg · 2024-07-09T02:17:11Z

@EmperorNumerius all of those files from the root of the project should not have been deleted.

jaspermayone · 2024-07-09T11:53:42Z

+1 on what luke said!

jaspermayone

Deleted files need to be readded, and all the contents of PurpleBubble need to be moved to the root directory.

jaspermayone · 2024-07-09T12:00:46Z

@EmperorNumerius you also need to address/resolve all the comments from the first round of comments.

Luke-Oldenburg · 2024-07-12T04:15:54Z

Is chatscope advanced enough for our purposes? The frontend should really support markdown and previewing files from links or at least showing it as a different blob from the main message like in iMessage.

EmperorNumerius · 2024-07-12T13:47:50Z

Is chatscope advanced enough for our purposes? The frontend should really support markdown and previewing files from links or at least showing it as a different blob from the main message like in iMessage.

then i need to use Stream Chat

polypixeldev

‎

jaspermayone · 2024-10-26T00:44:36Z

hi sam

EmperorNumerius added 5 commits July 5, 2024 09:42

created initial app

3bb2f17

creating login screen and registration screen

4034ddf

added chat screen and full registering and logiing

eb51bc1

finished app mvp

c659020

adding secrets

6f80e6c

aramshiva assigned EmperorNumerius Jul 6, 2024

aramshiva added the 💻 aspect: code Related to code implementation or modification. label Jul 6, 2024

jaspermayone requested a review from Luke-Oldenburg July 6, 2024 09:25

Luke-Oldenburg suggested changes Jul 6, 2024

View reviewed changes

Luke-Oldenburg requested a review from polypixeldev July 6, 2024 13:28

jaspermayone suggested changes Jul 6, 2024

View reviewed changes

Luke-Oldenburg changed the title ~~the app as an mvp from a tuotorial lol~~ Mobile App MVP using Firebase Jul 7, 2024

starting over with a expo app this time

fd87a56

spent rest of time reading purple bubble api

Luke-Oldenburg requested review from Luke-Oldenburg and jaspermayone July 9, 2024 02:15

jaspermayone suggested changes Jul 9, 2024

View reviewed changes

EmperorNumerius marked this pull request as draft July 9, 2024 23:16

playing around with

dd8f1d5

base chat ui

6334b08

polypixeldev reviewed Oct 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mobile App MVP using Firebase #1

Mobile App MVP using Firebase #1

EmperorNumerius commented Jul 6, 2024 •

edited by Luke-Oldenburg

Loading

aramshiva commented Jul 6, 2024 •

edited

Loading

jaspermayone commented Jul 6, 2024

jaspermayone commented Jul 6, 2024

Luke-Oldenburg left a comment

Luke-Oldenburg Jul 6, 2024

Luke-Oldenburg Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

jaspermayone left a comment

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

Luke-Oldenburg Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

jaspermayone Jul 6, 2024

aramshiva commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 8, 2024

Luke-Oldenburg commented Jul 9, 2024

jaspermayone commented Jul 9, 2024

jaspermayone left a comment

jaspermayone commented Jul 9, 2024

Luke-Oldenburg commented Jul 12, 2024

EmperorNumerius commented Jul 12, 2024

polypixeldev left a comment

jaspermayone commented Oct 26, 2024

		@@ -0,0 +1,2 @@
		BUNDLE_PATH: "vendor/bundle"
		BUNDLE_FORCE_RUBY_PLATFORM: 1

Mobile App MVP using Firebase #1

Are you sure you want to change the base?

Mobile App MVP using Firebase #1

Conversation

EmperorNumerius commented Jul 6, 2024 • edited by Luke-Oldenburg Loading

Pull Request

Description:

aramshiva commented Jul 6, 2024 • edited Loading

jaspermayone commented Jul 6, 2024

jaspermayone commented Jul 6, 2024

Luke-Oldenburg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

jaspermayone left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aramshiva commented Jul 6, 2024

Luke-Oldenburg commented Jul 6, 2024

Luke-Oldenburg commented Jul 8, 2024

Luke-Oldenburg commented Jul 9, 2024

jaspermayone commented Jul 9, 2024

jaspermayone left a comment

Choose a reason for hiding this comment

jaspermayone commented Jul 9, 2024

Luke-Oldenburg commented Jul 12, 2024

EmperorNumerius commented Jul 12, 2024

polypixeldev left a comment

Choose a reason for hiding this comment

jaspermayone commented Oct 26, 2024

EmperorNumerius commented Jul 6, 2024 •

edited by Luke-Oldenburg

Loading

aramshiva commented Jul 6, 2024 •

edited

Loading