Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Add email form #21

Merged
merged 27 commits into from
Dec 19, 2023
Merged

Add email form #21

merged 27 commits into from
Dec 19, 2023

Conversation

taciturnaxolotl
Copy link
Member

Add email form

Description:

Add the form and a Netlify function to proxy the request.

Related Issue:

Closes #18

@taciturnaxolotl taciturnaxolotl linked an issue Dec 14, 2023 that may be closed by this pull request
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for purplebubblewebsite ready!

Name Link
🔨 Latest commit 88f28dd
🔍 Latest deploy log https://app.netlify.com/sites/purplebubblewebsite/deploys/658086ffcc02fc0008d1d077
😎 Deploy Preview https://deploy-preview-21--purplebubblewebsite.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taciturnaxolotl taciturnaxolotl marked this pull request as ready for review December 18, 2023 01:16
Signed-off-by: Kieran Klukas <[email protected]>
@polypixeldev
Copy link
Contributor

goofy bug - bg image doesn't show by default but it does when i open devtools? firefox/linux
image

Copy link
Collaborator

@jaspermayone jaspermayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaspermayone
Copy link
Collaborator

Oh wait

@jaspermayone jaspermayone self-requested a review December 18, 2023 17:13
Copy link
Collaborator

@jaspermayone jaspermayone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix the above first

@taciturnaxolotl
Copy link
Member Author

@polypixeldev are you having the bg issue on the main site? https://purplebubble.org

@taciturnaxolotl
Copy link
Member Author

I just tested firefox, chrome, and safari on mac and they all worked fine.

@taciturnaxolotl
Copy link
Member Author

On a pixel 4 with chrome, it looks like below, which is a problem.
image

@taciturnaxolotl
Copy link
Member Author

Also works fine in firefox on arch linux with the weird issue of a lighter border than on my mac.
Photo Dec 18 2023 (1)
Photo Dec 18 181030

@polypixeldev
Copy link
Contributor

@polypixeldev are you having the bg issue on the main site? https://purplebubble.org

I am getting the same issue on main site

@taciturnaxolotl
Copy link
Member Author

weird; maybe its a config issue on your end? have you tried a private session or new profile?

@polypixeldev
Copy link
Contributor

I believe it was line 311 of style.css - an absolute path wasn't used. It's fixed in my PR #22, so feel free to merge this one!

@jaspermayone jaspermayone self-requested a review December 19, 2023 01:49
@taciturnaxolotl taciturnaxolotl merged commit b30c5c6 into main Dec 19, 2023
3 checks passed
@taciturnaxolotl taciturnaxolotl deleted the form branch December 19, 2023 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - HTML Form for mailing list signup
3 participants