Update an activities state #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
force-pushed
the
update-activities-state
branch
from
795ea11 to
64f2481
Compare
kkosiorowska
force-pushed
the
update-activities-state
branch
from
0f954ff to
b3e00ed
Compare
The previous solution was hard to understand what's the difference between transactions and activities. Instead of using the term transaction, we will keep all activities and use selectors to check which ones are completed. While `latestActivities` will be used to display notifications to the user.
kkosiorowska
force-pushed
the
update-activities-state
branch
from
6f45140 to
856bf19
Compare
Vitest is a next generation testing framework powered by Vite.
r-czajkowski
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
This PR updates the redux structure for activities. The previous state of activities was split into:
activities- All fetched activities.latestActivities- Activities used to display notifications to the user.The data needs to be updated, so the function that fetches the activities is called every 30 minutes. Additionally, activities will be fetched again after the deposit action.
Unit tests
This PR adds basic unit tests for
walletSlicereducer. To set up the test environment, the Vitest library was used. It is a new and fast testing framework recommended for the Vite project.