-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Much simpler route to upgrading 1.4.2 #153
base: master
Are you sure you want to change the base?
Conversation
Also I'll remake the travis PR immediately after you tell me if this is what was needed, @thlorenz |
Please run the update script as well so the ace files actually update. Once that's done run Then I can do the squashing and will publish a new version. |
Okay. Sorry about misunderstanding your instructions repeatedly. I'm very stupid when sick. This version of this PR:
|
OK, thanks I'm busy today but will merge and publish tomorrow granted all goes well. |
Thank you for an excellent tool, and putting up with my getting it wrong so many times Now that I know what I'm doing, I'm likely to submit more upgrades in the future, if that's acceptable to you. |
OK I tried to apply your change, but after removing all the white-space only changes, only the version ( So I reran the update script and got the same result:
I applied this to master but didn't publish for now. Could you please verify that this indeed includes the changes that should come with the new version. If all checks out I'll publish this as a new minor. |
- NOTE: only types and version were changed with this update (index.js and index.d.ts) - all other files had white-space only changes PR: #153
- NOTE: only types and version were changed with this update (index.js and index.d.ts) - all other files had white-space only changes PR: #153
Oh, also I removed the package-lock from the PR .. please don't add that in the future. |
Since this is actually so sketchy I removed this commit from master and pushed to a separate branch. Could you please do another upgrade, remove all white-space only changes so we can verify in a PR what actually DID change? It is really hard to tell with all the white-space noise. Thanks. |
I noticed that somehow a version change to The whitespace changes are on the Ace team actually (not your doing), but again it's really hard to see what's going on, so ideally remove them before submitting this as a PR. |
@thlorenz anything we can do to get this merged in? |
Overdoing it less this time, now that I know better