Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example/node_modules folder to fix npm install issues #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cstigler
Copy link

Summary

Removes the example/node_modules folder in order to fix some issues I found - specifically, I was unable to install brace from the GitHub repo using a recent version of npm.

Backstory

Using node 10.15.0 and npm 6.4.1, I was having issues installing brace. Specifically, it worked when I just used npm install brace, but not when I ran npm install brace@thlorenz/brace which should install the version on GitHub. I verified that this was the case even using alternative parameters, for example the https:// and git:// URLs.

When trying to install this repo from GitHub, I received a premature close error from npm, and upon further digging in the logs found the relevant error message: silly fetchPackageMetaData error for brace@github:thlorenz/brace premature close. Although this looks like a problem with the package.json file, I didn't see any.

After some investigation, it looks like the example/node_modules folder was causing the issues installing from GitHub. While I don't understand the npm install internals, my guess is that the symlinks are the cause of the issues.

Luckily, these seem to be very non-essential files - anybody looking to use the example can just run npm install themselves if they'd like - so deleting them seems like a good option to save frustration in the future!

Testing

Not much should be required, since this is only touching example files.

joelgardner added a commit to Radico/brace that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant