Removed abstract method. Now uses cast with supressed unchecck warning.

thorbenprimke · Nov 3, 2015 · 6a00f7b · 6a00f7b
1 parent 00f09b0
commit 6a00f7b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/example/app/build.gradle b/example/app/build.gradle
@@ -27,6 +27,6 @@ dependencies {
 
     compile 'com.android.support:recyclerview-v7:22.0.+'
 
-//    compile project(':library')
-    compile 'com.github.thorbenprimke:realm-recyclerview:0.9.1'
+    compile project(':library')
+//    compile 'com.github.thorbenprimke:realm-recyclerview:0.9.1'
 }
diff --git a/example/app/src/main/java/co/moonmonkeylabs/realmrecyclerview/example/MainActivity.java b/example/app/src/main/java/co/moonmonkeylabs/realmrecyclerview/example/MainActivity.java
@@ -179,11 +179,6 @@ public void onClick(View v) {
             }
             viewHolder.quoteTextView.setText(quoteModel.getQuote());
         }
-
-        @Override
-        public ViewHolder convertViewHolder(RealmViewHolder viewHolder) {
-            return ViewHolder.class.cast(viewHolder);
-        }
     }
 
     private void asyncAddQuote() {

diff --git a/example/app/src/main/java/co/moonmonkeylabs/realmrecyclerview/example/MainActivity2.java b/example/app/src/main/java/co/moonmonkeylabs/realmrecyclerview/example/MainActivity2.java
@@ -118,11 +118,6 @@ public void onClick(View v) {
                     }
             );
         }
-
-        @Override
-        public ViewHolder convertViewHolder(RealmViewHolder viewHolder) {
-            return ViewHolder.class.cast(viewHolder);
-        }
     }
 
     private void resetRealm() {

diff --git a/library/src/main/java/io/realm/RealmBasedRecyclerViewAdapter.java b/library/src/main/java/io/realm/RealmBasedRecyclerViewAdapter.java
@@ -148,8 +148,6 @@ public RealmBasedRecyclerViewAdapter(
 
     public abstract void onBindRealmViewHolder(VH holder, int position);
 
-    public abstract VH convertViewHolder(RealmViewHolder viewHolder);
-
     /**
      * DON'T OVERRIDE THIS METHOD. Implement onCreateRealmViewHolder instead.
      */
@@ -168,6 +166,7 @@ public RealmViewHolder onCreateViewHolder(ViewGroup viewGroup, int viewType) {
      * DON'T OVERRIDE THIS METHOD. Implement onBindRealmViewHolder instead.
      */
     @Override
+    @SuppressWarnings("unchecked")
     public void onBindViewHolder(RealmViewHolder holder, int position) {
         if (getItemViewType(position) == LOAD_MORE_VIEW_TYPE) {
             holder.loadMoreView.showSpinner();
@@ -186,7 +185,7 @@ public void onBindViewHolder(RealmViewHolder holder, int position) {
                     }
                     layoutParams.isHeader = true;
                 } else {
-                    onBindRealmViewHolder(convertViewHolder(holder), position);
+                    onBindRealmViewHolder((VH) holder, position);
                 }
                 layoutParams.setSlm(LinearSLM.ID);
                 if (header != null) {
@@ -196,7 +195,7 @@ public void onBindViewHolder(RealmViewHolder holder, int position) {
                 }
                 holder.itemView.setLayoutParams(layoutParams);
             } else {
-                onBindRealmViewHolder(convertViewHolder(holder), position);
+                onBindRealmViewHolder((VH) holder, position);
             }
         }
     }