Preserve executability of files for tar archives #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems that this PR only covers one very specific case and introduces quite a lot of changes just to make that one case work. i think it would be more useful to take a more general approach to #23 using the Java 7 features. |
|
@thrau yes, it covers "only" the most common and relevant use case, as preserving executability is a key feature of eg tar archives. there's not really many changes here, but you probably refer to fixing the inconsistent way factory has been handling imho best way forward would be to merge and do minor cleanup if necessary after #23 has been implemented. |
|
everything to make it work is essentially in specialized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributing to #23