Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL issue #1700

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix URL issue #1700

merged 1 commit into from
Feb 18, 2025

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Feb 17, 2025

Pull Request Description

This PR fixes an issue with parsing links in markdown where, if the text and the hyperlink both resolved to a valid URL, we would prioritize the text instead of the link.

Issue Being Fixed

Issue Number: Comment that demonstrates the issue: https://programming.dev/comment/15039739

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

hjiangsu
hjiangsu approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice catch!

@hjiangsu hjiangsu merged commit 1ce3be7 into thunder-app:develop Feb 18, 2025
1 check passed
@micahmo micahmo deleted the fix/url-issue branch February 18, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu