Initial ability to share and open links in Thunder on iOS #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
commented
Oct 31, 2023
| @@ -0,0 +1,360 @@ | |||
| // | |||
There was a problem hiding this comment.
TODO: This file still needs to be cleaned up as it is retrieved from the template of the package.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR introduces the ability to open and share links on iOS though the share extension.
This differs slightly to the Android implementation in that it opens up the given post/user/comment/instance if it detects the incoming link to be a Lemmy link. This is because there's no current way to open up Lemmy links on Thunder through iOS, and it seems like the most likely use-case for sharing a Lemmy link is to open the link within the app.
This is still in draft as more testing is required (for media, and other types of links) and I would like to implement the ability to open links for communities as well if possible.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?