User store extended settings store #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelissaAutumn
approved these changes
Jan 20, 2025
...t/migrations/versions/2025_01_15_1340-4a15d01919b8_add_config_fields_to_subscribers_table.py
Outdated
Show resolved
Hide resolved
...t/migrations/versions/2025_01_15_1340-4a15d01919b8_add_config_fields_to_subscribers_table.py
Outdated
Show resolved
Hide resolved
frontend/src/stores/user-store.ts
Outdated
| // Init user config if not already available | ||
| if (!data.value?.settings) { | ||
| const dj = inject(dayjsKey); | ||
| const detectedTimeFormat = Number(dj('2022-05-24 20:00:00').format('LT').split(':')[0]) > 12 ? 24 : 12; |
There was a problem hiding this comment.
I think using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/hourCycle will work better?
There was a problem hiding this comment.
The hourCycle property turned out to not being meant to work for detection. It is just a property already coded in the locale, e.g. the "h23" in "fr-FR-u-hc-h23". The function actually providing time format information for locales is https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getHourCycles but thats not yet working in Firefox, unfortunately.
Co-authored-by: Mel <[email protected]>
Co-authored-by: Mel <[email protected]>
Co-authored-by: Mel <[email protected]>
…15d01919b8_add_config_fields_to_subscribers_table.py Co-authored-by: Mel <[email protected]>
…15d01919b8_add_config_fields_to_subscribers_table.py Co-authored-by: Mel <[email protected]>
Co-authored-by: Mel <[email protected]>
Co-authored-by: Mel <[email protected]>
Co-authored-by: Mel <[email protected]>
|
Looks like backend tests are broken right now |
|
Yes, I'm on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change
Benefits
Settings are now saved and restored consistently over multiple devices.
Applicable Issues
Closes #804