closes #140

CHANGELOG.md

@@ -4,6 +4,7 @@ CHANGELOG
 ## 1.5.1 (`1050170`)
 
 - **Fix:** Template content is not displayed when editing template modification (#139)
+- **Fix:** Unable to select hidden file-based email transport on XenForo 2.3 (#140)
 
 ## 1.5.0 (`1050070`)
 

XF/Admin/Controller/Option.php

@@ -5,7 +5,10 @@
 use XF\Entity\Option as OptionEntity;
 use XF\Entity\OptionGroup as OptionGroupEntity;
 use XF\Mvc\Entity\ArrayCollection;
-use XF\Mvc\Reply\View;
+use XF\Mvc\ParameterBag;
+use XF\Mvc\Reply\View as ViewReply;
+use XF\Mvc\Reply\Redirect as RedirectReply;
+use XF\Mvc\Reply\Exception as ExceptionReply;
 
 /**
  * Class Option
@@ -39,4 +42,29 @@ public function optionAddEdit(OptionEntity $option, $baseRelations = [])
 
         return $reply;
     }
+
+    /**
+     * @since 1.5.1
+     *
+     * @param ParameterBag $params
+     *
+     * @return RedirectReply|ViewReply
+     *
+     * @throws ExceptionReply
+     */
+    public function actionEmailTransportSetup(ParameterBag $params)
+    {
+        $option = $this->assertEmailTransportOption($params->option_id);
+
+        $newType = $this->filter('new_type', 'str');
+        if ($this->isPost() && ($newType === 'file'))
+        {
+            $optionValue = ['emailTransport' => $newType];
+            $this->getOptionRepo()->updateOption($option->option_id, $optionValue);
+
+            return $this->redirect($this->getDynamicRedirect());
+        }
+
+        return parent::actionEmailTransportSetup($params);
+    }
 }

_output/phrases/tckDeveloperTools_file.txt

@@ -0,0 +1 @@
+File

_output/phrases/tckDeveloperTools_hidden_file_based_email_transport.txt

@@ -0,0 +1 @@
+Hidden file-based email transport

_output/template_modifications/admin/developerTools_option_template_emailTransport.json

@@ -1,6 +1,6 @@
 {
     "template": "option_template_emailTransport",
-    "description": "Enable hidden file-based email transport option",
+    "description": "Enable hidden file-based email transport option (XF 2.2)",
     "execution_order": 6119,
     "enabled": true,
     "action": "str_replace",

_output/template_modifications/admin/tckDevTools_option_template_advancedEmailTransport.json

@@ -0,0 +1,9 @@
+{
+    "template": "option_template_advancedEmailTransport",
+    "description": "Custom label for email transport method is using \"file\" type",
+    "execution_order": 6119,
+    "enabled": true,
+    "action": "preg_replace",
+    "find": "{(^\\s<xf:if is=\"\\$option\\.option_value\\.emailTransport.*?>.*?)(<xf:else \\/>$)}sm",
+    "replace": "$1<xf:elseif is=\"$option.option_value.emailTransport == 'file'\" />\n\t\t<div>{{ phrase('tckDeveloperTools_hidden_file_based_email_transport') }}</div>\n\t$2"
+}

_output/template_modifications/admin/tckDeveloperTools_option_email_transport_setup_a.json

@@ -0,0 +1,9 @@
+{
+    "template": "option_email_transport_setup",
+    "description": "Enable hidden file-based email transport option (XF 2.3)",
+    "execution_order": 6119,
+    "enabled": true,
+    "action": "str_replace",
+    "find": "<xf:option value=\"smtp\"",
+    "replace": "\t<xf:option value=\"file\">{{ phrase('tckDeveloperTools_file') }}</xf:option>\n$0"
+}

_output/template_modifications/admin/tckDeveloperTools_option_email_transport_setup_b.json

@@ -0,0 +1,9 @@
+{
+    "template": "option_email_transport_setup",
+    "description": "Enable hidden file-based email transport option (XF 2.3)",
+    "execution_order": 6119,
+    "enabled": true,
+    "action": "str_replace",
+    "find": "$option.option_value.emailTransport|to_upper",
+    "replace": "($option.option_value.emailTransport == 'file') ? phrase('tckDeveloperTools_hidden_file_based_email_transport') : $0"
+}