Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy_to overwrite flag #1580

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

liudvikasakelis
Copy link

Fixes #1535.
While the report mentions duckdb, I chose to write test in SQLite due to there being no other duckdb tests yet. Issue seems backend agnostic anyway.
Will be grateful for reviews :)

@liudvikasakelis liudvikasakelis marked this pull request as draft February 7, 2025 18:57
@liudvikasakelis liudvikasakelis marked this pull request as ready for review February 12, 2025 11:16
@liudvikasakelis
Copy link
Author

After some test wrangling, I think this is ready for review. In summary:

  • proposed test case I think captures the gist of the bug, even if in SQLite. This case fails without the fix and passes with it.
  • reprex provided in the issue copy_to(overwrite=TRUE) not working in duckdb and dbplyr #1535 succeeds without error with provided fix (tested manually)
  • errors seen in GH automated checks:
    • test-tbl-sql.R:33:3 - already present in commit 5726930 (tested locally). It's a simple fix but I'm unsure if this PR is the best place 🤷
    • test-backend-postgres.R:341:3 - already present in commit 5726930 (tested locally)
    • test-backend-postgres.R:367:3 - already present in commit 5726930 (tested locally)
    • test-coverage 'has been automatically failed' due to deprecated version

i.e. the fix addresses the issue and doesn't introduce more bugs, to the best of my knowledge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy_to(overwrite=TRUE) not working in duckdb and dbplyr
1 participant