-
Notifications
You must be signed in to change notification settings - Fork 343
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
42 additions
and
117 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,26 @@ | ||
## Submission summary | ||
|
||
This is a major rewrite which replaces use of the XML package with xml2 (thus avoiding many memory leaks). This is a large change, so I gave the downstream maintainers plenty of time to respond. | ||
* Fixes failing url in examples. | ||
* Also includes two minor bug fixes. | ||
|
||
## Test environments | ||
|
||
* local OS X install, R 3.1.2 | ||
* ubuntu 12.04 (on travis-ci), R 3.1.2 | ||
* local OS X install, R 3.2.1 | ||
* ubuntu 12.04 (on travis-ci), R 3.2.2 | ||
* win-builder (devel and release) | ||
|
||
## R CMD check results | ||
|
||
There were no ERRORs or WARNINGs. | ||
|
||
There was 1 NOTE: | ||
|
||
* I have changed the maintainer address to [email protected]. I'll send | ||
a confirmation from my old address shortly. | ||
There was one NOTE: | ||
|
||
* There was a false positive for "found the following (possibly) invalid URLs": | ||
the vignette includes a javascript bookmarklet which starts with | ||
`javascript:`. | ||
* "Found the following (possibly) invalid URLs: URL: javascript:(...)" - | ||
this is a false positive. It's a valid used to embed a JS bookmarklet in | ||
a vignette. | ||
|
||
## Downstream dependencies | ||
|
||
* I ran R CMD check on all 7 downstream dependencies. (Summary at | ||
* I ran R CMD check on all 9 downstream dependencies. (Summary at | ||
https://github.com/hadley/rvest/blob/master/revdep/summary.md) | ||
|
||
* There are three new failures: | ||
|
||
* gsheet, nhanesA: uses deprecated function | ||
* wikipediatrend: uses deprecated function, test now fails | ||
|
||
* I notified all downstream maintainers on Sep 2 that release would happen on | ||
Sep 22. I notified them again today. | ||
* There were no new failures |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,27 +6,28 @@ | |
|:--------|:----------------------------| | ||
|version |R version 3.2.1 (2015-06-18) | | ||
|system |x86_64, darwin13.4.0 | | ||
|ui |RStudio (0.99.674) | | ||
|ui |RStudio (0.99.747) | | ||
|language |(EN) | | ||
|collate |en_US.UTF-8 | | ||
|tz |America/Chicago | | ||
|date |2015-09-22 | | ||
|date |2015-11-06 | | ||
|
||
## Packages | ||
|
||
|package |* |version |date |source | | ||
|:--------|:--|:-------|:----------|:--------------| | ||
|httr | |1.0.0 |2015-06-25 |CRAN (R 3.2.0) | | ||
|knitr | |1.10.5 |2015-05-06 |CRAN (R 3.2.0) | | ||
|magrittr | |1.5 |2014-11-22 |CRAN (R 3.2.0) | | ||
|png | |0.1-7 |2013-12-03 |CRAN (R 3.2.0) | | ||
|selectr | |0.2-3 |2014-12-24 |CRAN (R 3.2.0) | | ||
|stringi | |0.5-5 |2015-06-29 |CRAN (R 3.2.0) | | ||
|testthat |* |0.10.0 |2015-05-22 |CRAN (R 3.2.0) | | ||
|xml2 | |0.1.2 |2015-09-01 |CRAN (R 3.2.0) | | ||
|package |* |version |date |source | | ||
|:---------|:--|:-------|:----------|:--------------| | ||
|httr | |1.0.0 |2015-06-25 |CRAN (R 3.2.0) | | ||
|knitr | |1.10.5 |2015-05-06 |CRAN (R 3.2.0) | | ||
|magrittr | |1.5 |2014-11-22 |CRAN (R 3.2.0) | | ||
|png | |0.1-7 |2013-12-03 |CRAN (R 3.2.0) | | ||
|rmarkdown | |0.7 |2015-06-13 |CRAN (R 3.2.0) | | ||
|selectr | |0.2-3 |2014-12-24 |CRAN (R 3.2.0) | | ||
|stringi | |1.0-1 |2015-10-22 |CRAN (R 3.2.0) | | ||
|testthat |* |0.11.0 |2015-10-14 |CRAN (R 3.2.0) | | ||
|xml2 | |0.1.2 |2015-09-01 |CRAN (R 3.2.0) | | ||
|
||
# Check results | ||
7 checked out of 7 dependencies | ||
8 checked out of 9 dependencies | ||
|
||
## gsheet (0.1.0) | ||
Maintainer: Max Conway <[email protected]> | ||
|
@@ -53,36 +54,20 @@ Maintainer: Jonathan Callahan <[email protected]> | |
|
||
__OK__ | ||
|
||
## nhanesA (0.5) | ||
## nhanesA (0.6.1) | ||
Maintainer: Christopher Endres <[email protected]> | ||
|
||
``` | ||
checking examples ... WARNING | ||
Found the following significant warnings: | ||
Warning: 'html' is deprecated. | ||
Warning: 'html' is deprecated. | ||
Warning: 'html' is deprecated. | ||
Warning: 'html' is deprecated. | ||
Warning: 'html' is deprecated. | ||
Warning: 'html' is deprecated. | ||
Deprecated functions may be defunct as soon as of the next release of | ||
R. | ||
See ?Deprecated. | ||
``` | ||
``` | ||
DONE | ||
Status: 1 WARNING | ||
``` | ||
__OK__ | ||
|
||
## rex (1.0.1) | ||
Maintainer: Jim Hester <[email protected]> | ||
Bug reports: https://github.com/kevinushey/rex/issues | ||
|
||
__OK__ | ||
|
||
## rNOMADS (2.1.4) | ||
Maintainer: Daniel C. Bowman <[email protected]> | ||
## rscopus (0.1.2) | ||
Maintainer: John Muschelli <[email protected]> | ||
Bug reports: https://github.com/muschellij2/rscopus/issues | ||
|
||
__OK__ | ||
|
||
|
@@ -92,76 +77,23 @@ Bug reports: https://github.com/trulia/choroplethr/issues | |
|
||
__OK__ | ||
|
||
## wikipediatrend (1.1.6) | ||
## sejmRP (1.2) | ||
Maintainer: Piotr Smuda <[email protected]> | ||
Bug reports: http://github.com/mi2-warsaw/sejmRP/issues | ||
|
||
__OK__ | ||
|
||
## wikipediatrend (1.1.7) | ||
Maintainer: Peter Meissner <[email protected]> | ||
Bug reports: https://github.com/petermeissner/wikipediatrend/issues | ||
|
||
``` | ||
checking package dependencies ... NOTE | ||
Packages suggested but not available for checking: | ||
‘AnomalyDetection’ ‘BreakoutDetection’ | ||
``` | ||
``` | ||
checking examples ... WARNING | ||
Found the following significant warnings: | ||
Warning: 'rvest::html' is deprecated. | ||
Warning: 'rvest::html' is deprecated. | ||
Deprecated functions may be defunct as soon as of the next release of | ||
R. | ||
See ?Deprecated. | ||
``` | ||
``` | ||
checking tests ... ERROR | ||
Running the tests in ‘tests/testthat.R’ failed. | ||
Last 13 lines of output: | ||
11: Ops.data.frame(dings, dongs) | ||
12: matrix(unlist(value, recursive = FALSE, use.names = FALSE), nrow = nr, dimnames = list(rn, | ||
cn)) | ||
Error : expecting a single value | ||
testthat results ================================================================ | ||
OK: 63 SKIPPED: 0 FAILED: 3 | ||
1. Failure (at test_caching_gathering.R#27): normal usage | ||
2. Failure (at test_caching_gathering.R#39): setting cache file | ||
3. Error: cache reset | ||
Error: testthat unit tests failed | ||
Execution halted | ||
``` | ||
``` | ||
checking re-building of vignette outputs ... NOTE | ||
Error in re-building vignettes: | ||
... | ||
http://stats.grok.se/json/en/201508/Millennium_Development_Goals | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/es/201506/Objetivos_de_Desarrollo_del_Milenio | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/es/201507/Objetivos_de_Desarrollo_del_Milenio | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/es/201508/Objetivos_de_Desarrollo_del_Milenio | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/en/201506/Millennium_Development_Goals | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/en/201507/Millennium_Development_Goals | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/en/201508/Millennium_Development_Goals | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/en/201508/Cheese | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
http://stats.grok.se/json/de/201508/K%C3%A4se | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
Error in eval(expr, envir, enclos) : expecting a single value | ||
Quitting from lines 286-289 (using-wikipediatrend.Rmd) | ||
Error: processing vignette 'using-wikipediatrend.Rmd' failed with diagnostics: | ||
expecting a single value | ||
Execution halted | ||
``` | ||
``` | ||
DONE | ||
Status: 1 ERROR, 1 WARNING, 2 NOTEs | ||
Status: 1 NOTE | ||
``` | ||
|