revert(behavior_velocity): revert unknown traffic light handling PR6036 #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
requested review from
satoshi-ota,
shmpwk,
tkimura4,
rej55,
isamu-takagi,
kosuke55,
kyoichi-sugahara,
mkuri,
maxime-clem,
taikitanaka3,
takayuki5168 and
TomohitoAndo
as code owners
soblin
commented
Dec 3, 2024
| if (!tl_info_opt) { | ||
| // the info of this traffic light is not available | ||
| return false; | ||
| } | ||
| const auto & tl_info = tl_info_opt.value(); | ||
| const auto & tl_info = *tl_info_opt; | ||
| for (auto && tl_light : tl_info.signal.elements) { |
There was a problem hiding this comment.
tl_info_optがnullptrでないかを確認しているので，落ちない
| if (!tl_info_opt) { | ||
| return TrafficPrioritizedLevel::NOT_PRIORITIZED; | ||
| } | ||
| const auto & tl_info = tl_info_opt.value(); | ||
| const auto & tl_info = *tl_info_opt; |
There was a problem hiding this comment.
tl_info_optがnullptrでないかを確認しているので，落ちない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
なるべく https://github.com/autowarefoundation/autoware.universe/pull/6036/files のdiffを再現するように修正
以下の画像で一番左: オリジナル, 一番右: 今回
crosswalk
same as before
behavior_velocity_planner_node
same as before
planner_data
same as before
Related links
Parent Issue:
How was this PR tested?
対応する信号をunknownにするとtraffic_lightの壁が出ることを確認
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.