Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove conflicting version from CHANGELOG.rst #134

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 12, 2025

PR Type

  • Bug Fix

Related Links

https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/13238122114/job/36947354593?pr=119

Description

The 2022.05.0 version in the CHANGELOG.rst file is causing bloom to fail as it interprets it's newer than 0.41.0. This is making our buildfarm fail with the following message:

BLOOM_SKIP_ROSDEP_UPDATE=1 bloom-generate rosdebian --os-name=ubuntu --os-version=jammy --ros-distro=humble
/usr/lib/python3/dist-packages/pkg_resources/__init__.py:116: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  warnings.warn(
==> Generating debs for ubuntu:jammy for package(s) ['autoware_external_api_msgs']
No homepage set, defaulting to ''
/usr/lib/python3/dist-packages/pkg_resources/__init__.py:116: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  warnings.warn(
ROS Distro index file associate with commit '215aa06e3250a27834448b8efa281be34d92f7c5'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/215aa06e3250a27834448b8efa281be34d92f7c5/index-v4.yaml'
No historical releaser history, using current maintainer name and email for each versioned changelog entry.

The version of the first changelog entry '0.41.0' is not the same as the version being currently released '2022.05.0'.

There is at least one changelog entry, '2022.05.0', which has a newer version than the version of package 'autoware_external_api_msgs' being released, '0.41.0'.
This is almost certainly by mistake, you should really take a look at the changelogs for the package you are releasing.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@esteve
Copy link
Contributor Author

esteve commented Feb 12, 2025

@youtalk can you please review this when you have a moment? I don't have permission to assign this PR to a reviewer. Thanks.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@esteve
Copy link
Contributor Author

esteve commented Feb 12, 2025

@youtalk thanks for the quick review 🙂 Feel free to merge this PR when you can, I don't have write access.

@youtalk youtalk merged commit 278e32d into tier4:tier4/universe Feb 12, 2025
9 checks passed
@youtalk
Copy link
Member

youtalk commented Feb 12, 2025

I have re-tagged the latest commit with 0.41.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants