*: remove api mode concept #8952
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
rleungx
force-pushed
the
rename-api
branch
2 times, most recently
from
cb81d98 to
806f172
Compare
rleungx
force-pushed
the
rename-api
branch
4 times, most recently
from
3c8d130 to
b2765f0
Compare
rleungx
requested review from
lhy1024 and
okJiang
and removed request for
lhy1024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8952 +/- ##
==========================================
+ Coverage 74.91% 76.34% +1.42%
==========================================
Files 416 465 +49
Lines 42103 70550 +28447
==========================================
+ Hits 31543 53859 +22316
- Misses 7810 13344 +5534
- Partials 2750 3347 +597
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
| @@ -116,7 +116,7 @@ func MicroserviceRedirectRule(matchPath, targetPath, targetServiceName string, | |||
| } | |||
|
|
|||
| func (h *redirector) matchMicroServiceRedirectRules(r *http.Request) (bool, string) { | |||
| if !h.s.IsAPIServiceMode() { | |||
| if !h.s.IsPDServiceMode() { | |||
There was a problem hiding this comment.
How about IsMicroServiceMode?
pkg/mcs/scheduling/server/server.go
Outdated
| @@ -220,7 +220,7 @@ func (s *Server) updateAPIServerMemberLoop() { | |||
| // double check | |||
| break | |||
| } | |||
| if s.cluster.SwitchAPIServerLeader(pdpb.NewPDClient(cc)) { | |||
| if s.cluster.SwitchPDLeader(pdpb.NewPDClient(cc)) { | |||
There was a problem hiding this comment.
How about SwitchPDServiceLeader
| // flagFromAPIServer has no influence for pd mode, but it is useful for us to debug in api mode. | ||
| flagFromAPIServer = "from_api_server" | ||
| // flagFromPDService has no influence for pd mode, but it is useful for us to debug in pd service mode. | ||
| flagFromPDService = "from_api_server" |
There was a problem hiding this comment.
Do we need to change "from_api_server"?
There was a problem hiding this comment.
I didn't change it before because I'm afraid there is a compatibility issue. Since it is not GA now, I'm going to change it.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
@niubell PTAL |
|
/retest |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024, niubell, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/hold cancel |
ti-chi-bot
bot
removed
the
do-not-merge/hold
What problem does this PR solve?
Issue Number: ref #8477
What is changed and how does it work?
This PR changes the following things:
pdService*toservice*in client, pd service can be used only in microservice mode.apiSvc*andpdSvc*in client and change the name toservice*pd modeandpd service modeto distinguish whether PD is in microservice mode, previously we useapi*Check List
Tests
Release note