Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional instructions for Windows + changed CMakeLists.txt #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zelourses
Copy link
Contributor

Added:

  • Windows build instructions into readme.md

Changed:

  • now CMakeLists.txt for every benchmark will generate right test for Windows.

About Windows build:
Sadly, original command cmake --build build/Release just won't work at all. Every time when I try to use it, msvc cannot find cppbenchmark headers. Why? I still do not fully understand. But the combination of "not creating additional folder for release build" and running cmake --build --preset conan-release gives an expected result.

Sadly, --preset requires CMake 3.19, and I cannot find any information about which version of VS build tools provides which version of CMake to write it down into readme.md

P.S. I am not quite sure about black magic inside add_test and my NOINLINE macro. As per my tests, they work on msvc and gcc as expected

Verified

This commit was signed with the committer’s verified signature.
Added:
 - Windows build instructions to `readme.md`

Changed:
 - now `CMakeLists.txt` for every benchmark will generate right test for
   Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant