Additional instructions for Windows + changed CMakeLists.txt #5
+195
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
readme.md
Changed:
CMakeLists.txt
for every benchmark will generate right test for Windows.About Windows build:
Sadly, original command
cmake --build build/Release
just won't work at all. Every time when I try to use it, msvc cannot findcppbenchmark
headers. Why? I still do not fully understand. But the combination of "not creating additional folder for release build" and runningcmake --build --preset conan-release
gives an expected result.Sadly,
--preset
requires CMake 3.19, and I cannot find any information about which version of VS build tools provides which version of CMake to write it down intoreadme.md
P.S. I am not quite sure about black magic inside
add_test
and myNOINLINE
macro. As per my tests, they work on msvc and gcc as expected