Implement query parameter when searching for PR's
#1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1937 Add `query` argument to `gs_github_pull_request` (default: "") to filter the list of PR's we fetch. As the search API does return a subset of the information we need, query the full PR response in a second step (but in the background using a future). The query parameter is a string and can be basically anything a user would also type in on Github's website. Interesting candidates are e.g. "involves:@me" which is also added to the Command Palette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937
Add
queryargument togs_github_pull_request(default: "") to filterthe list of PR's we fetch. As the search API does return a subset of
the information we need, query the full PR response in a second step
(but in the background using a future).
The query parameter is a string and can be basically anything a user
would also type in on Github's website.
Interesting candidates are e.g. "involves:@me" which is also added to
the Command Palette.