Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running an export, drop project items with no content with a warning #328

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

timrogers
Copy link
Owner

@timrogers timrogers commented Nov 8, 2024

Fixes #85.

@timrogers timrogers force-pushed the timrogers/no-content branch from 9243ee3 to e256ffd Compare November 8, 2024 18:00
@timrogers timrogers force-pushed the timrogers/no-content branch from e256ffd to 5c36e44 Compare November 8, 2024 18:02
@timrogers timrogers marked this pull request as ready for review November 8, 2024 18:11
@timrogers timrogers requested a review from Copilot November 8, 2024 18:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/commands/export.ts:242

  • Ensure that there are tests verifying that project items without content are skipped and that the appropriate warnings are logged.
const validProjectItems = allProjectItems.filter((projectItem) => {

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@timrogers
Copy link
Owner Author

The GHES 3.15 instance is out of action right now, but I'm going to merge this anyway.

@timrogers timrogers merged commit 6e74710 into main Nov 15, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading '__typename')
1 participant