Fix litra-oversight's compatibility with Oversight 2.1.8+ by accepting new -activeCount argument
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing `-activeCount` argument `litra-oversight` allows you to automatically turn your Litra on/off when your webcam turns on and off in connection with [OverSight][1]. OverSight can be pointed at the `litra-oversight` command to enable this kind of automation. OverSight calls the specified CLI with a number of arguments. v2.1.8 [added][2] a new `-activeCount` argument that is passed. We don't actually need this or care about it, but since it isn't an allowlisted argument, we error and the integration breaks down. This allows `litra-oversight` to accept but ignore that argument, getting thingss working again. Fixes #259. [1]: https://github.com/objective-see/OverSight [2]: objective-see/OverSight#48
|
🎉 This PR is included in version 4.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
litra-oversightallows you to automatically turn your Litra on/off when your webcam turns on and off in connection with OverSight. OverSight can be pointed at thelitra-oversightcommand to enable this kind of automation.OverSight calls any specified command with a number of arguments. v2.1.8 added a new
-activeCountargument that is passed.We don't actually need this or care about it, but since it isn't an allowlisted argument, we currently error, leaving the integration broken.
This allows
litra-oversightto accept but ignore that argument, getting things working again. An alternative approach would be to allow and ignore any argument - but I'm not sure how easy that will be to do with Commander, so I'm taking this approach for now.Fixes #259.