Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx service annotations: #136

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Oct 24, 2024

Description

Allows customization for things like load balancer.

Why is this needed

Fixes: #62
Fixes: #123

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Allows customization for things like
load balancer.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 97f3c5c into tinkerbell:main Oct 24, 2024
3 checks passed
@jacobweinstock jacobweinstock deleted the nginx-annotations branch October 24, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for annotations on loadbalancer service
1 participant