charts: stack: introduce stack.clusterDomain to replace hardcoded cluster.local values
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rpardini, thanks for this! Mind updating your commit to have a DCO signoff? ref: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md |
…uster.local' values Signed-off-by: Ricardo Pardini <[email protected]>
rpardini
force-pushed
the
stack-add-clusterDomain
branch
from
3502656 to
ed84639
Compare
|
Ooops sorry I forgot. Done. |
jacobweinstock
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charts: stack: introduce stack.clusterDomain to replace hardcoded
cluster.localvaluesDescription
Use a value instead of
cluster.localhardcoded in a few places.Why is this needed
Some clusters might not have cluster.local domain, although it is the default.