Update bmclib version: #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a nil pointer panic when running in environments (container images like scratch) that don't have the "sum" binary. In bmclib the "sum" binary is the supermicro update manager, but in most OS distros "sum" is a command for "checksum and count the blocks in a file". This means that we didn't see the panic because we are running in Alpine that have a "sum" binary. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 46.80% 46.80%
=======================================
Files 11 11
Lines 1361 1361
=======================================
Hits 637 637
Misses 666 666
Partials 58 58 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a nil pointer panic when running in environments (container images like scratch) that don't have the "sum" binary. In bmclib the "sum" binary is the supermicro update manager, but in most OS distros "sum" is a command for "checksum and count the blocks in a file". This means that we didn't see the panic because we are running in Alpine that has a "sum" binary.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: