Fix how we check for OSIE.BaseURL:

The object that gets returned from Kubernetes seems to always come back non-nil. So we need to also check if the string is empty. Signed-off-by: Jacob Weinstock <[email protected]>
tinkerbell · Jan 30, 2025 · ad251cd · ad251cd
1 parent afd6b7a
commit ad251cd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/ipxe/script/ipxe.go b/internal/ipxe/script/ipxe.go
@@ -287,7 +287,7 @@ func (h *Handler) defaultScript(span trace.Span, hw data) (string, error) {
 		Retries:               h.IPXEScriptRetries,
 		RetryDelay:            h.IPXEScriptRetryDelay,
 	}
-	if hw.OSIE.BaseURL != nil {
+	if hw.OSIE.BaseURL != nil && hw.OSIE.BaseURL.String() != "" {
 		auto.DownloadURL = hw.OSIE.BaseURL.String()
 	}
 	if hw.OSIE.Kernel != "" {