Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge alpha 8 #1

Open
wants to merge 136 commits into
base: master
Choose a base branch
from
Open

Conversation

mihailapuste
Copy link

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:

Update the documentation

If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.

Update the changelog

After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

Provide an example of how to test the change

If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.

Focus the PR on only one area

Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.

Describe the changes

Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

Romick2005 and others added 30 commits March 3, 2023 16:47
…for error: 'what' (AVAudioSessionErrorCodeUnspecified).
Print error for configureAudio method try catch blocks.
Adds `namespace` prop which is required by Gradle 8 (dep. of RN 0.73)
…ios-fix

* commit '23a39e8f5fffbbdcfc72a4c0d7777763e273cd6d':
  chore: fix build issue
  Update issue templates
  feat: RN 0.73 support
  Fix ids in exo_player_control_view
  fix: remove dummy nativeOnly
TheWidlarzGroup#3166 Memory leaks
TheWidlarzGroup#3085 onFullscreen call backs are never fired
TheWidlarzGroup#3040 [Bug] Fullscreen broken on iOS due to TheWidlarzGroup#3017
chrisglein and others added 30 commits September 18, 2023 18:08
The native code was receiving the event, but not reasing the event.
Which [apparently](microsoft/react-native-windows#4206) needs to be prefixed with "top" and then that turns into "onError".

Note that this raises the event, but no error object is included. Better than nothing.
…mp-ci-node-version

chore(ci): bump actions node version
Fix: Not showing video ads when the PIP mode is enabled on iOS
Remove explicit SDK version for Windows builds
fix: Player shows black screen on re-enter (iOS)
This reverts commit c991a0e.
In order to avoid big conflicts with TheWidlarzGroup#3015
…date-namespace-handler

chore(android): fix react native 0.73 support
…code_17_beta

fix: fix build on xcode 17 beta
…codec-supported-update

feat(android): update `isCodecSupported` to return enum
…mp-example-react-native-version

chore(example/basic): bump react native version
…yback-ref-functions

feat: expose playback functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.