tools: add pubmed tool #1044
Open
tools: add pubmed tool #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longkeyy
force-pushed
the
add_tool_pubmed
branch
from
6bad095 to
1f6e285
Compare
FluffyKebab
reviewed
Jan 5, 2025
| ) | ||
|
|
||
| // DefaultUserAgent defines a default value for user-agent header. | ||
| const DefaultUserAgent = "github.com/tmc/langchaingo/tools/pubmed" |
There was a problem hiding this comment.
It think it would be better if this isn't exported and was set by the new function if the userAgent string is empty.
|
|
||
| // New initializes a new PubMed Search tool with arguments for setting a | ||
| // max results per search query and a value for the user agent header. | ||
| func New(maxResults int, userAgent string) (*Tool, error) { |
There was a problem hiding this comment.
What do you think about having functions options here instead? Then we could have a default for maxResults and the ability to pass callbacks.Handler in the New function.
| "github.com/tmc/langchaingo/tools/pubmed/internal" | ||
| ) | ||
|
|
||
| func TestNew(t *testing.T) { |
There was a problem hiding this comment.
Does these test need to be mocked? It seems like the tests test the internal client. Maybe we can put this file in the internal package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.Fixes #1043