Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to have gelu activations #9

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Add option to have gelu activations #9

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8044192
add option to have gelu activations
brianhie Feb 18, 2024
ca6401c
default to silu
brianhie Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ def __init__(
super().__init__()

multiple_of = config.get("inner_size_multiple_of", 64)
self.act = F.silu
self.act_type = config.get("mlp_activation", "gelu")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this now, should we actually default to "silu" given that silu is the current default activation? @Zymrael @exnx

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a min, it's supposed to be gelu, at least that's what the ckpts all use. This is a source of error accumulation during inference I remember that. I thought I changed it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exnx it's changed in other repos. not in togethercomputer/stripedhyena though.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's default to silu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

if self.act_type == "gelu":
self.act = F.gelu
elif self.act_type == "silu":
self.act = F.silu
else:
raise NotImplementedError

self.multiple_of = multiple_of * config.model_parallel_size

inner_size = int(2 * config.hidden_size * 4 / 3)
Expand Down