Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typos documentation comments in mat4.js #479

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

LordArugula
Copy link
Contributor

@LordArugula LordArugula commented Nov 13, 2024

In the doc comments for the fromRotationTranslation... functions, quat4 is used as the type instead of quat. See https://github.com/toji/gl-matrix/blob/master/src/mat4.js#L1048

Also fixes typo mentioned in #419

@toji
Copy link
Owner

toji commented Nov 15, 2024

Thank you!

@toji toji merged commit fdab302 into toji:master Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants