Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the fix for register_testnet_via_faucet #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

the fix for register_testnet_via_faucet #182

wants to merge 1 commit into from

Conversation

olexiyb
Copy link

@olexiyb olexiyb commented Aug 21, 2019

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

https://github.com/tokenika/eosfactory/blob/master/docs/tutorials/05.InteractingWithPublicTestnet.md

the command from tutorial

python3 -m eosfactory.register_testnet_via_faucet http://faucet.cryptokylin.io http://145.239.133.201:9999 mykylin
created incorrect information in ~/eosio-wallet/testnet.json

  • What is the new behavior (if this is a feature change)?

With a fix it works as expected

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

@olexiyb olexiyb changed the title incorrect testnet information added the fix for register_testnet_via_faucet Aug 21, 2019
stefanzarembinski
stefanzarembinski reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@stefanzarembinski stefanzarembinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you.

stefanzarembinski
stefanzarembinski reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@stefanzarembinski stefanzarembinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanzarembinski stefanzarembinski stefanzarembinski left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olexiyb @stefanzarembinski @olexiybuyanskyy