Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove unnecessary toolchain install step #3126

Closed
wants to merge 1 commit into from

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Dec 27, 2024

If a rust-toolchain file exists, then that toolchain should be used by default anyway

If a `rust-toolchain` file exists, then that toolchain should be used by default anyway
@Turbo87 Turbo87 marked this pull request as ready for review December 27, 2024 22:23
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the rust-cache action wants the toolchain you're going to be using for the CI job to be installed by the time it runs, for proper caching.

@catuhana
Copy link
Contributor

Instead caching with GitHub's official cache action could be used, though it requires a bit of manual configuration.

On another note, wouldn't it be better to move the toolchain file to the root?

@jplatte
Copy link
Member

jplatte commented Dec 28, 2024

Instead caching with GitHub's official cache action could be used, though it requires a bit of manual configuration.

What problem would this be solving?

On another note, wouldn't it be better to move the toolchain file to the root?

No, I don't want to force contributors to have that specific nightly always. It's really only needed for stable output of the trybuild tests in the macro crate.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 30, 2024

I'm pretty sure the rust-cache action wants the toolchain you're going to be using for the CI job to be installed by the time it runs, for proper caching.

hmm, you appear to be right. I was assuming that rust-cache looks at the rust-toolchain file, but maybe not, or maybe it doesn't care about a file being in a subfolder 🤔

@Turbo87 Turbo87 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants