Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u-boot: send hardening warning messages to stderr #68

Merged

Conversation

rborn-tx
Copy link
Collaborator

Send most of the hardening warning/error messages to U-Boot's stderr to increase the chances they are seen.

Related-to: #64

Send most of the hardening warning/error messages to U-Boot's stderr to
increase the chances they are seen.

Signed-off-by: Rogerio Guerra Borin <[email protected]>
@rborn-tx rborn-tx self-assigned this Sep 27, 2024
@jsrc27
Copy link
Contributor

jsrc27 commented Sep 27, 2024

Do you think the following warning/error messages also need to be sent to stderr?:

+ printf("whitelist feature requires a valid FDT blob\n");

(same on upstream)

(same on upstream)

Or are these different compared to the messages changed in this PR?

@rborn-tx
Copy link
Collaborator Author

Do you think the following warning/error messages also need to be sent to stderr?:

@jsrc27 Good question!

Basically in this PR I chose to send to stderr only messages starting with a double hash mark; those are the messages I considered (during development) as being important and more likely to happen (of course based on personal guess).

The messages you highlighted of course are important (same as hundreds of other errors U-Boot might detect, unrelated to the hardening) but they should be detected during development in which case I'd expect nobody to be executing U-Boot with stdout redirected to nulldev for example.

@jsrc27
Copy link
Contributor

jsrc27 commented Sep 27, 2024

@rborn-tx Okay that makes sense just wanted to check/confirm. No other comments from my side then.

Copy link
Collaborator

@sergioprado sergioprado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergioprado sergioprado merged commit 6451f30 into toradex:kirkstone-6.x.y Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants