Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove unused extra params from ShareRequestItem #99

Merged
merged 3 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/TorusUtils/Helpers/NodeUtils.swift
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ internal class NodeUtils {
publicKey: extraParams.publicKey,
challenge: extraParams.challenge,
rpOrigin: extraParams.rpOrigin,
rpId: extraParams.rpId
rpId: extraParams.rpId,
timestamp: extraParams.timestamp
)

importedItems.append(shareRequestItem)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,34 +24,16 @@ internal struct ShareRequestParams: Codable {

// TODO: This is a bit of a mess from here due to legacy reasons and should be cleaned up in future.
// Note: Nil values by default are excluded from serialization
public var enable_verifier_id_hash: Bool? // most
public var app_s: String? // meta
public var app_id: String? // meta
public var domain: String? // farcaster
public var nonce: String? // farcaster
public var message: String? // farcaster
public var signature: String? // farcaster, passkey, webauthn
public var clientDataJson: String? // passkey, webauthn
public var authenticatorData: String? // passkey, webauthn
public var publicKey: String? // passkey, webauthn
public var challenge: String? // passkey, webauthn
public var rpOrigin: String? // passkey, webauthn
public var rpId: String? // passkey, webauthn
public var jwk_endpoint: String? // passkey, jwt
public var default_node_set: [String]? // passkey, jwt
public var jwt_verifier_id_field: String? // passkey, jwt
public var jwt_verifier_id_case_sensitive: Bool? // passkey, jwt
public var jwk_keys: String? // passkey, jwt
public var jwt_validation_fields: [String]? // passkey, jwt
public var jwt_validation_values: [String]? // passkey, jwt
public var index: Int? // demo
public var email: String? // demo
public var id: String? // test, jwt, passkey
public var correct_id_token: String? // test
public var verify_param: String? // OrAggregate
public var threshold: Int? // SingleID
public var pub_k_x: String? // Signature
public var pub_k_y: String? // Signature
var nonce: String? // farcaster
var message: String? // farcaster
var signature: String? // farcaster, passkey, webauthn
var clientDataJson: String? // passkey, webauthn
var authenticatorData: String? // passkey, webauthn
var publicKey: String? // passkey, webauthn
var challenge: String? // passkey, webauthn
var rpOrigin: String? // passkey, webauthn
var rpId: String? // passkey, webauthn
var timestamp: Int? // Signature
}

public var encrypted: String = "yes"
Expand Down
2 changes: 1 addition & 1 deletion Torus-utils.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |spec|
spec.name = "Torus-utils"
spec.version = "9.0.0"
spec.version = "9.0.1"
spec.ios.deployment_target = "13.0"
spec.summary = "Retrieve user shares"
spec.homepage = "https://github.com/torusresearch/torus-utils-swift"
Expand Down