Separate WASM lib #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project shouldn't have two locks files. removing yarn.lock because we seem to be using package-lock.json more commonly in the context of tss.
- revise client lib for easier upgrading through usage of wasm-pack with --omit-default-module-path - add tss-lib-wasm package that separately holds the wasm file. this allows loading the wasm from a package on demand and keeping the size of tss-lib low.
metalurgical
reviewed
May 9, 2024
|
Please add a PR to dkls for this with updated build instructions this as well. |
Thanks for the reminder! 🙏 |
|
added tests and ci as well |
added 2 commits
May 16, 2024 12:24
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactor of the WASM lib.
Background: We want to have the same interface for FROST and DKLS libs, so that they can be integrated easily within MPC Core Kit. WASM should be packaged separately, so that we can keep size of core kit bundle low.