push-based messaging #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, will approve once CI passes. |
|
we will need the @toruslabs/tss-client-util to be published for this. @himanshuchawla009 can you help? |
matthiasgeihs
force-pushed
the
feat/push-messaging
branch
from
a42b81c to
c583345
Compare
|
Looks good, there's some vulnerability fixes that can be applied (see npm audit) |
|
@himanshuchawla009 what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes to change to push-based messaging (instead of the currently used poll-based messaging) for more performance.
Depends on
MapQueuefrom@toruslabs/tss-client-utilwhich needs to be released first.