-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github(workflow): Add tensorflow dependencies to golangci-lint #103
Conversation
The workflow was always failing since it did not have the required tensorflow dependencies. This commit fixes it by making use of the makefile to install the dependency inside the workflow.
WalkthroughThe update introduces enhancements to the CI/CD pipeline by incorporating steps to install necessary dependencies and configure environment variables specifically for CGO within the GitHub Actions workflow. This adjustment ensures a smoother integration and build process, particularly for projects that rely on CGO for calling C code from Go. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/golangci-lint.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/golangci-lint.yml (2)
24-25
: Ensure themake check-tensorflow
command is idempotent to avoid unnecessary reinstallation of dependencies. Consider adding a comment in the Makefile or workflow to clarify this behavior.
27-31
: Verify the path$HOME/src/tensorflow
used inCGO_CFLAGS
is correct and consistently points to the TensorFlow headers. Consider adding a step to check if the directory exists or if the headers are correctly installed to prevent potential issues during compilation.
The workflow was always failing since it did not have the required tensorflow headers in the workflow. Causing it to fail with errors such as:
Fixing it by making sure that the tensorflow headers are downloaded before running the linting.
Summary by CodeRabbit