Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize fetching of tensorflow header files #104

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

isZumpo
Copy link
Contributor

@isZumpo isZumpo commented Apr 5, 2024

Rather than cloning the whole tensorflow repository, which is rather large, clone only the header files. Accomplished by utilizing sparse checkout feature.

During testing, cloning tensorflow like this was over 5 times faster than the old approach. It can be optimized further by limiting which folders to grab header files from too. However, currently I am not too familiar with how the header files are dependent on each-other, so I decided not to go for the extreme "tensorflow/lite/**/*.h" pattern which I was able to build and run the application with, since some of the headers there had dependencies to tensorflow/core.

Summary by CodeRabbit

  • Chores
    • Improved the download and retrieval processes for TensorFlow headers by configuring sparse checkout in the Dockerfile and Makefile.

Rather than cloning the whole tensorflow repository,
which is rather large, clone only the header files. Accomplished
by utilizing sparse checkout feature.

During testing cloning tensorflow like this was over 5 times faster
than the old approach. It can be optimized further by limiting which
folders to grab header files from too.
Copy link
Contributor

coderabbitai bot commented Apr 5, 2024

Walkthrough

The recent modifications involve integrating additional Git commands into both the Dockerfile and Makefile. These commands are specially designed to set up a sparse checkout process for TensorFlow headers. This adjustment aims to streamline the download and retrieval stages, making them more efficient and less resource-intensive by focusing only on the necessary parts of the TensorFlow repository.

Changes

Files Change Summary
Dockerfile, Makefile Added Git commands for sparse checkout of TensorFlow headers

🌟✨
In the land of code and byte,
Where Docker sails and Makefiles fight,
A rabbit hopped with glee tonight,
For TensorFlow's load grew light.
Sparse checkout, the wizards' might,
Made our builds both swift and right.
🚀🐰💫

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4c839a3 and 2e10fa7.
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • Makefile (1 hunks)
Additional comments not posted (2)
Dockerfile (1)

34-37: Consider refining the sparse checkout pattern to be more specific to the required TensorFlow header files, if a thorough analysis of dependencies allows for it. This could further optimize the fetching process by reducing the amount of data cloned even more. However, ensure that all necessary dependencies are included to avoid build issues.

Makefile (1)

36-39: Consider refining the sparse checkout pattern in the Makefile to be more specific to the required TensorFlow header files, if a thorough analysis of dependencies allows for it. This could further optimize the fetching process by reducing the amount of data cloned even more. However, ensure that all necessary dependencies are included to avoid build issues.

@tphakala tphakala merged commit 75880c3 into tphakala:main Apr 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants