-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event tracker fixes #393
Event tracker fixes #393
Conversation
tphakala
commented
Jan 15, 2025
- Event tracker functionality was using hard coded interval values, fixed code to use realtime.interval value instead
- MQTT publish action frequency was not controlled by event tracker
- Updated the event tracking logic in LogAction, DatabaseAction, BirdWeatherAction, and MqttAction to return early if the event should not be tracked, improving code clarity and reducing unnecessary processing. - Refactored logging for file and database operations to ensure errors are properly logged and handled. - Enhanced the BirdWeatherAction to include a confidence threshold check before uploading data, ensuring only relevant data is processed. - Overall, these changes improve the maintainability and efficiency of the action execution flow.
- Added a new EventTrackerConfig struct to hold various configuration intervals for event tracking. - Modified the NewEventTracker function to accept a time.Duration parameter, allowing for dynamic configuration of event handler intervals. - Updated the EventTracker initialization in the processor to utilize the new configuration based on settings. These changes enhance the flexibility and customization of event tracking behavior in the application.
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces modifications to event tracking mechanisms across multiple files in the Changes
Sequence DiagramsequenceDiagram
participant Processor
participant EventTracker
participant Actions
Processor->>EventTracker: Initialize with interval
EventTracker-->>Processor: Configured tracker
Actions->>EventTracker: Check event tracking
alt Event is tracked
Actions->>Actions: Execute action
else Event not tracked
Actions-->>Actions: Early return
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #351 |