Fix Make for headless, which currently steals focus
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cimbali
changed the title
Cimbali
changed the title
Make for headless, which was not asynchronous
Cimbali
changed the title
Make for headless, which was not asynchronousMake for headless, which currently steals focus
|
I had some concerns about this I never got around to expressing, but as it happens, the job support should render this moot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All strategies for
Makework as:Except for the headless strategy, which is a synchronous build, basically a synonym for
make.This very simple PR fixes this by allowing the headless Make to be asynchronous, making it more similar to other backends for Make and actually useful between
makeandMake!makeMakeMake!