-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package pkg renamed into internal vol.2 #8
base: master
Are you sure you want to change the base?
Package pkg renamed into internal vol.2 #8
Conversation
@piotrkowalczuk you have to run |
Done. A few tests are failing, the same that fails on the master. @pires do you consider any package from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to be honest with you and while looking at these changes I'm asking myself if whatever gains justify the effort and risk they carry. I wanted to be inclusive and take in mind any contributions, and I know you've tried to contribute long time ago, but I'm a bit anxious 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pires Up to you man ;)
New attempt to move files located in
pkg
directory intointernal
. A completely fresh start as it was quite impossible to rebase the branch after so many changes. Plus I don't have permission to origin anymore.I encountered an issue:
I'm not able to find
github.com/travelaudience/aerospike-operator/pkg/client
package onmaster
.cc @pires
It is related to #1.