fix: build-secret flag not being set breaking build.py
#7993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rets checks to accurately evaluate the state of the dictionary.
rmccorm4
requested review from
nv-kmcgill53 and
mc-nv
and removed request for
nv-kmcgill53
|
@pvijayakrish I believe this change is touching part of code which you introduced recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
secretschecks inbuild.pyto accurately evaluate the state of the dictionary so as to not set empty docker build flags that cause errors when building thetritonserverimage.Full details in #7992