Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Puppet 8 and PDK 3 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to Puppet 8 and PDK 3 #17

wants to merge 1 commit into from

Conversation

tuxmea
Copy link

@tuxmea tuxmea commented Feb 16, 2024

fixes #15

xenon8
xenon8 suggested changes Jan 28, 2025
View reviewed changes
Copy link

@xenon8 xenon8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, standard upgrade using the PDK to Puppet 8. My code comment would be to update the version number in the metadata json file, as indicated.

metadata.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the version number to 2.0.0, as we are moving to Puppet 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenon8 xenon8 xenon8 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please update Puppet compatibility to Puppet 8
2 participants
@tuxmea @xenon8