Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130509 / 25.04 / Add CI test for discovery auth #15010

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

bmeagherix
Copy link
Contributor

Add a CI unit test test__discover_from_initiator that ensures that Discovery auth operates as expected.

It will use ISCSIDiscover which is a wrapper around some functionality that we pushed upstream into cython-iscsi.

@bmeagherix bmeagherix added the WIP label Nov 21, 2024
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Add CI test for discovery auth NAS-130509 / 25.04 / Add CI test for discovery auth Nov 21, 2024
@bmeagherix
Copy link
Contributor Author

Added a test robustness change to address intermittent test failure.

Did some shortcut tests to verify in CI 1951, 1952, 1953.

@bmeagherix bmeagherix merged commit b078b47 into master Nov 22, 2024
2 of 3 checks passed
@bmeagherix bmeagherix deleted the NAS-130509 branch November 22, 2024 10:18
@bmeagherix bmeagherix removed the WIP label Nov 22, 2024
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants