Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133930 / 25.10 / Clean-up device info plugin #15550

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Feb 1, 2025

This cleans up the device info module.

  1. remove methods that were only used in unit tests? The actual method wasn't called anywhere...
  2. remove methods that aren't called anywhere else
  3. move the tty serial information to ups module since that's the only caller
  4. remove unused imports

@yocalebo yocalebo requested a review from a team February 1, 2025 13:18
@bugclerk
Copy link
Contributor

bugclerk commented Feb 1, 2025

@bugclerk bugclerk changed the title Clean-up device info plugin NAS-133930 / 25.10 / Clean-up device info plugin Feb 1, 2025
@truenas truenas deleted a comment from bugclerk Feb 1, 2025
@yocalebo yocalebo merged commit 5164210 into master Feb 10, 2025
2 checks passed
@yocalebo yocalebo deleted the cleanup-devinfo branch February 10, 2025 15:38
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants