Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134097 / 25.10 / Bring back original test_system_general_ui_rollback.py #15645

Merged

Conversation

themylogin
Copy link
Contributor

Rewritten test is double the code and fails always, not sometimes. Let's roll back, see how the original code flakes and fix that.

@themylogin themylogin requested a review from a team February 7, 2025 18:23
@bugclerk bugclerk changed the title Bring back original test_system_general_ui_rollback.py NAS-134097 / 25.10 / Bring back original test_system_general_ui_rollback.py Feb 7, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Feb 7, 2025

1 similar comment
@bugclerk
Copy link
Contributor

bugclerk commented Feb 7, 2025

@themylogin
Copy link
Contributor Author

time 0:05

@themylogin themylogin merged commit 8fb117e into master Feb 7, 2025
2 checks passed
@themylogin themylogin deleted the bring-back-original-test_system_general_ui_rollback branch February 7, 2025 18:26
@bugclerk
Copy link
Contributor

bugclerk commented Feb 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants