Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject mismatched schematic location edits #460

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Adds validation to skip location edits whose original_center does not match the manualEditsFile

Changes

  • Added validation in applyEditEventsToManualEditsFile to check if original_center matches current position
  • Added test case to verify edit events with mismatched positions are rejected
  • For new placements, only allow if original_center is {0,0} (default position)

Testing

  • Added new test case that verifies edit events are rejected when original_center doesn't match
  • Verified all existing tests continue to pass
  • Type checking and formatting pass

Link to Devin run: https://app.devin.ai/sessions/d8259b27b88c4c41a928d95c2d6c18b6

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Copy link

github-actions bot commented Jan 1, 2025

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants