Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate source_component.display_value for R/C #464

Closed
wants to merge 2 commits into from
Closed

Populate source_component.display_value for R/C #464

wants to merge 2 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Closes #463

Link to Devin run: https://app.devin.ai/sessions/109ab29c284941aeb145014057c2002a

This PR adds display_value population for resistor and capacitor components:

  • Adds proper unit symbols (Ω for resistors, µF for capacitors)
  • Handles both string and number input formats
  • Sets display_value during source component creation
  • Includes tests verifying correct display value formatting

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@seveibar seveibar closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate source_component.display_value for resistors and capacitors
1 participant
@seveibar