testing elkjs bundle size #469
Conversation
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
|
@seveibar this library is huge |
|
@seveibar looks like it needs to be run with node not bun |
|
oh wow yea that's big. I'm a bit hesitant to pull in something that big... |
|
@ShiboSoftwareDev Having schematic layout be async and allowing for external schematic layout is fine- but we should determine if elkjs actually works before we put too much effort into it. If it does work, we'll use the async layout engine until we have a decent synchronous layout engine. But let's see if it can do layout with circuits with a bunch of traces before we commit to that! |
|
@seveibar I'll do a bunch if tests and configure the algorithm properly and see how it does |
|
it's pretty good for placements but you'd have to manage your own traces |
|
what I did here is I made the doInitialSchematicTraceRender wait on the layout to be complete |
|
@seveibar i can go forward and configure the algorithm and make more circuits but I want to know what you say about the traces first |
|
@ShiboSoftwareDev im not sure, i think we need a more representative circuit. Something like the esp32 that Anas put together |
|
This one would also work, its tricky because it uses other snippets that cant be loaded into a test case, but this is the kind of layout that is pretty common and important for the autolayout engine to do properly https://tscircuit.com/seveibar/rp2040-module |
|
This is the one i mentioned from Anas that's a pretty good representative layout, can't find that actual snippet though 😭 CC @AnasSarkiz
|
|
@seveibar I'll yalc push core to snippets and test with the auto-load snippets feature |
this is just testing the bundle size
I also discovered some issue, If I remove the workerUrl to try to run it synchronously it breaks here's a related issue: oven-sh/bun#15737